Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ adds FY Select to CANs List #2882

Merged
merged 19 commits into from
Oct 7, 2024
Merged

feat: ✨ adds FY Select to CANs List #2882

merged 19 commits into from
Oct 7, 2024

Conversation

fpigeonjr
Copy link
Contributor

@fpigeonjr fpigeonjr commented Oct 3, 2024 •
edited
Loading

What changed

  • adds Fiscal Year Select for CANs List

Issue

#347 #2878

How to test

  1. Goto CANs list
  2. see list filtered by FY
  3. select another FY from drop-down
  4. see list update based on selected FY
  5. 💰 profit

Screenshots

Screen.Recording.2024-10-04.at.3.40.55.PM.mov

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • [-] Form validations updated

@fpigeonjr fpigeonjr added the javascript Pull requests that update Javascript code label Oct 3, 2024
@fpigeonjr fpigeonjr self-assigned this Oct 3, 2024
@fpigeonjr fpigeonjr changed the title Ops 347/2878 wip: adds FY Select to CANs List Oct 3, 2024
@fpigeonjr fpigeonjr linked an issue Oct 4, 2024 that may be closed by this pull request
filter by Fiscal Year #2878
Closed
@fpigeonjr fpigeonjr marked this pull request as ready for review October 4, 2024 20:35
@fpigeonjr fpigeonjr changed the title wip: adds FY Select to CANs List faet: ✨ adds FY Select to CANs List Oct 4, 2024
@fpigeonjr fpigeonjr changed the title faet: ✨ adds FY Select to CANs List feat: ✨ adds FY Select to CANs List Oct 4, 2024
@jonnalley
Copy link
Contributor

🪄

@fpigeonjr fpigeonjr merged commit b414999 into main Oct 7, 2024
40 checks passed
@fpigeonjr fpigeonjr deleted the OPS-347/2878 branch October 7, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maiyerlee maiyerlee maiyerlee approved these changes

@rajohnson90 rajohnson90 rajohnson90 approved these changes

@johndeange johndeange johndeange approved these changes

@devops-chris devops-chris Awaiting requested review from devops-chris

@Santi-3rd Santi-3rd Awaiting requested review from Santi-3rd

Assignees

@fpigeonjr fpigeonjr

Labels
javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

filter by Fiscal Year
5 participants
@fpigeonjr @jonnalley @johndeange @rajohnson90 @maiyerlee