Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ adds active period filter to CANs list #2889

Merged
merged 37 commits into from
Oct 9, 2024
Merged

feat: ✨ adds active period filter to CANs list #2889

merged 37 commits into from
Oct 9, 2024

Conversation

fpigeonjr
Copy link
Contributor

@fpigeonjr fpigeonjr commented Oct 7, 2024 •
edited
Loading

What changed

  • adds active period filter to CANs list
  • does not include tags

Issue

#347 #2888

How to test

  1. goto CANs list
  2. click on filter button
  3. select an active period
  4. see table update with filter
  5. 💰 profit

Screenshots

Screen.Recording.2024-10-07.at.4.44.42.PM.mov

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • [-] Form validations updated

@fpigeonjr fpigeonjr self-assigned this Oct 7, 2024
@fpigeonjr fpigeonjr added the javascript Pull requests that update Javascript code label Oct 7, 2024
@fpigeonjr fpigeonjr linked an issue Oct 7, 2024 that may be closed by this pull request
filter by active period(s) #2888
Closed
@fpigeonjr fpigeonjr changed the title wip: active period filter for CANs list feat: ✨ adds active period filter to CANs list Oct 7, 2024
@fpigeonjr fpigeonjr marked this pull request as ready for review October 7, 2024 21:42
@jonnalley
Copy link
Contributor

📈

fpigeonjr
fpigeonjr commented Oct 8, 2024
View reviewed changes
frontend/src/components/CANs/CANTable/CANTable.jsx
@@ -23,7 +19,7 @@ const CANTable = ({ cans, fiscalYear }) => {
// Filter CANs by fiscal year
const filteredCANsByFiscalYear = React.useMemo(() => {
if (!fiscalYear) return cans;
return cans.filter((can) => can.funding_budgets.some((budget) => budget.fiscal_year === fiscalYear));
return cans.filter((can) => can.funding_details.fiscal_year === fiscalYear);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @johndeange for calling this out

maiyerlee
maiyerlee approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@maiyerlee maiyerlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👏👏

@fpigeonjr fpigeonjr merged commit 4490678 into main Oct 9, 2024
40 checks passed
@fpigeonjr fpigeonjr deleted the OPS-347/2888 branch October 9, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnalley jonnalley jonnalley left review comments

@maiyerlee maiyerlee maiyerlee approved these changes

@rajohnson90 rajohnson90 rajohnson90 approved these changes

@johndeange johndeange Awaiting requested review from johndeange

@devops-chris devops-chris Awaiting requested review from devops-chris

@Santi-3rd Santi-3rd Awaiting requested review from Santi-3rd

Assignees

@fpigeonjr fpigeonjr

Labels
javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

filter by active period(s)
4 participants
@fpigeonjr @jonnalley @rajohnson90 @maiyerlee