Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: 💅 UX Review fixes #2934

Merged
merged 5 commits into from
Oct 16, 2024
Merged

style: 💅 UX Review fixes #2934

merged 5 commits into from
Oct 16, 2024

Conversation

fpigeonjr
Copy link
Contributor

@fpigeonjr fpigeonjr commented Oct 15, 2024 •
edited
Loading

What changed

fixes UX review items

Issue

#347

How to test

  1. e2e tests pass

Screenshots

image

image
Screen.Recording.2024-10-15.at.5.20.59.PM.mov

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • [-] Form validations updated

@fpigeonjr fpigeonjr self-assigned this Oct 15, 2024
@fpigeonjr fpigeonjr added the javascript Pull requests that update Javascript code label Oct 15, 2024
jonnalley
jonnalley approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@jonnalley jonnalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

engage!

@fpigeonjr fpigeonjr changed the title style: UX Review fixes style: 💅 UX Review fixes Oct 15, 2024
@kimschulke kimschulke merged commit 7f7fbb9 into main Oct 16, 2024
40 checks passed
@kimschulke kimschulke deleted the OPS-347/ux_feedback branch October 16, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimschulke kimschulke kimschulke approved these changes

@jonnalley jonnalley jonnalley approved these changes

@johndeange johndeange Awaiting requested review from johndeange

@devops-chris devops-chris Awaiting requested review from devops-chris

@maiyerlee maiyerlee Awaiting requested review from maiyerlee

@Santi-3rd Santi-3rd Awaiting requested review from Santi-3rd

@rajohnson90 rajohnson90 Awaiting requested review from rajohnson90

@npage123 npage123 Awaiting requested review from npage123

Assignees

@fpigeonjr fpigeonjr

Labels
javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fpigeonjr @jonnalley @kimschulke