Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "https://www.grants.gov/web/grants/search-grants.html" links with a working link #60

Closed
4 tasks
pcraig3 opened this issue Nov 22, 2024 · 2 comments
Closed
4 tasks

Comments

@pcraig3
Copy link
Collaborator

pcraig3 commented Nov 22, 2024

Summary

Some of the grants have a link to what is meant to be the grants search page (https://www.grants.gov/web/grants/search-grants.html), but if you click it, it 404s you.

Now, lots of links 404 but this one actually says it's a 200, so our external link checker isn't able to actually verify that it is working or not.

The solution for this URL is:

Whenever we see this link:

Swap it for this one:

There's also an opportunity here to look through the NOFOs for the links they have and pull them out individually. Apparently, all www.grants.gov/web/* domains will secretly 404 on people.

Tasks

  • Add in code to replace https://www.grants.gov/web/grants/search-grants.html on import
  • Add a script to pull links out of existing NOFOs
  • Swap all the existing https://www.grants.gov/web/grants/search-grants.html URLs
  • Determine if there is more to do here
@pcraig3
Copy link
Collaborator Author

pcraig3 commented Nov 22, 2024

@pcraig3
Copy link
Collaborator Author

pcraig3 commented Nov 22, 2024

Merged #64 and that resolves this, so all good.

@pcraig3 pcraig3 closed this as completed Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant