Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify patient/category search for DiagnosticReport #16

Open
jmandel opened this issue Aug 21, 2019 · 8 comments
Open

Clarify patient/category search for DiagnosticReport #16

jmandel opened this issue Aug 21, 2019 · 8 comments

Comments

@jmandel
Copy link

jmandel commented Aug 21, 2019

http://build.fhir.org/ig/HL7/US-Core-R4/StructureDefinition-us-core-diagnosticreport-lab.html#mandatory-search-parameters uses an example with a specific category (LAB). Is this the only category for which a server needs to support search? If so, should add this to the header that currently just says ("SHALL support searching using the combination of the patient and category search parameters")

(And... what should a server do if another category is supplied by the client?)

@brettmarquard
Copy link
Contributor

brettmarquard commented Aug 21, 2019

That particular profile is 'scoped' to lab only -- is this page more clear for the generic DiagnosticReport Notes profile?
https://build.fhir.org/ig/HL7/US-Core-R4/StructureDefinition-us-core-diagnosticreport-note.html

@jmandel
Copy link
Author

jmandel commented Aug 21, 2019

Note that the same issue comes up on other pages where the text says "by category" but the example suggests that only a single (fixed) category value needs to be supported. E.g. http://build.fhir.org/ig/HL7/US-Core-R4/StructureDefinition-us-core-careplan.html#mandatory-search-parameters

@jmandel
Copy link
Author

jmandel commented Aug 21, 2019

@brettmarquard the other example you linked to says:

SHALL support searching using the combination of the patient and code search parameters:

... which I take to mean that a client can supply any code it wants, and the search should work. (So in that case, for DiagnosticReport notes, the code isn't "fixed in place" to a single value.)

@brettmarquard
Copy link
Contributor

The mentioned profiles (us-core-careplan, and us-core-diagnosticreport-lab) have 'fixed' categories. @jmandel Should we add a note in implementation guidance to make that clear?

@Healthedata1
Copy link
Collaborator

Healthedata1 commented Aug 26, 2019

The quick start is generated using a script and template. And the search parameter is fixed in the formal notation. but not in the text since is describing the parameter in general. also mention in the implementation notes. Do you have a suggestion for making it clearer. WE will try to avoid manually editing these and update the script if possible.

@jmandel
Copy link
Author

jmandel commented Aug 26, 2019

My suggestion would be instead of

SHALL support searching using the combination of the patient and category search parameters:

to say

SHALL support searching using the patient search parameter with a fixed category

Or something to that effect. If you want to try to address this purely within the "Implementation Notes," then state "The server SHALL support queries with a fixed category of http://hl7.org/fhir/us/core/CodeSystem/careplan-category|assess-plan and MAY support other categories."

@Healthedata1
Copy link
Collaborator

I will need to defer this til later not trivial change to the script right now.

@brettmarquard
Copy link
Contributor

brettmarquard commented Sep 3, 2019

This won't be resolved prior to STU comment period -- @Healthedata1 will review new ways to generate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants