Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-subscription needs clarification #319

Open
matthiaswilder opened this issue Jul 1, 2020 · 0 comments
Open

Re-subscription needs clarification #319

matthiaswilder opened this issue Jul 1, 2020 · 0 comments

Comments

@matthiaswilder
Copy link

matthiaswilder commented Jul 1, 2020

Currently the spec suggests that re-subscription is supported by including the hub.channel.endpoint parameter in a subscription request. However, it makes no mention of re-subscription in the Subscription Denial/Confirmation sections. In those sections the language is written as if the subscriber will always need to connect to a websocket before receiving a confirmation/denial, but in re-subscription the subscriber has presumably already connected.

The obvious solution to me here is that the confirmation/denial is sent automatically, since the connection is already open. But I have had at least one person suggest that this implies another behavior where the subscriber reconnects to the websocket on every re-subscription.

I think that language calling out permutations of the subscription for re-subscription should probably be more explicit and less inferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant