-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Update PushKit to the latest version and upgrade to AndroidX from Support or remove it completely #11
Comments
@entdark Thanks for your feedback. I suggest you upgrade to version 6.3.0.304 and try again. |
I tried the latest version and it depends on Support library. None uses Support libraries anymore. |
I literally linked you the place where it is used in the code. |
@entdark Thank you for your feedback. We have understood your suggestions and will consider optimization later. |
+, package must depend on AndroidX not on Support library |
+, I'm also waiting this issue to be resolved |
Platform: Android
The issue is here:
hms-xamarin-bindings/android/nuspecs/Huawei.Hms.Push.5.0.4.302.nuspec
Line 17 in c77c1bb
Push kit bindings contain some helpers that are special addition:
hms-xamarin-bindings/android/source/push/Additions/HMSPush/Util/Utils.cs
Line 21 in c77c1bb
Original push kit does not depend on those. So I'd suggest to remove those helpers or move them to another new NuGet. It's up to the final user how to display notifications and we should not depend on Support or AndroidX at all.
The text was updated successfully, but these errors were encountered: