Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Update PushKit to the latest version and upgrade to AndroidX from Support or remove it completely #11

Open
entdark opened this issue Oct 12, 2022 · 7 comments

Comments

@entdark
Copy link

entdark commented Oct 12, 2022

Platform: Android
The issue is here:

<dependency id="Xamarin.Android.Support.v4" version="28.0.0.3" />

Push kit bindings contain some helpers that are special addition:
Original push kit does not depend on those. So I'd suggest to remove those helpers or move them to another new NuGet. It's up to the final user how to display notifications and we should not depend on Support or AndroidX at all.

@xuxiapu
Copy link

xuxiapu commented Oct 12, 2022

@entdark Thanks for your feedback. I suggest you upgrade to version 6.3.0.304 and try again.

@entdark
Copy link
Author

entdark commented Oct 13, 2022

I tried the latest version and it depends on Support library. None uses Support libraries anymore.

@entdark
Copy link
Author

entdark commented Oct 13, 2022

I literally linked you the place where it is used in the code.

@xuxiapu
Copy link

xuxiapu commented Oct 18, 2022

@entdark Thank you for your feedback. We have understood your suggestions and will consider optimization later.

@MaximAfanasenko
Copy link

+, package must depend on AndroidX not on Support library

@lexboss777
Copy link

+, I'm also waiting this issue to be resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants