Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virtual/hybrid/in-person tags for events #1343

Open
klieret opened this issue Feb 6, 2023 · 1 comment
Open

Add virtual/hybrid/in-person tags for events #1343

klieret opened this issue Feb 6, 2023 · 1 comment

Comments

@klieret
Copy link
Member

klieret commented Feb 6, 2023

As suggested by @wdconinc

@klieret
Copy link
Member Author

klieret commented Feb 6, 2023

Looks good. Is there a use for a tag virtual, hybrid, in-person? Not sure how tags are defined and if we can just add them by text.

Unfortunately we'd need to switch a bit because of this:

 {% for tag in post.tags %} 
<a href="{{ '/training/our-events.html' | relative_url }}" title="Organized/supported by HSF">
<span class="badge badge-success">{{ tag }}</span></a>
 {% endfor %}

arguably a bad way of implementing the current system, too (mea culpa).

But basically the issue is that we'd need a merge of a second config of tag -> style, url and this might not be trivial.

One way could be to make this a separate extension and then have a long list of if, elif statements checking the type of tag that has been added... (or looping over a tag config and for every tag checking if it is included in the list of tags)
Another is to use one of the hacky ways to parse JSON in liquid (none of them seem much nicer than that)

Let me ping @henryiii if he can think of something quick & elegant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant