Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DT-5977 Varely config #4868

Merged
merged 5 commits into from
Oct 9, 2023
Merged

DT-5977 Varely config #4868

merged 5 commits into from
Oct 9, 2023

Conversation

sharhio
Copy link
Contributor

@sharhio sharhio commented Oct 2, 2023

Proposed Changes

  • Varely real-time data
  • Rauma data to Varely
  • Varely datat to Matka

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build
  • Code coverage does not decrease (unless measured incorrectly)

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

@sharhio sharhio changed the title Dt 5977 DT-5977 Varely config Oct 2, 2023
optionsome
optionsome requested changes Oct 3, 2023
View reviewed changes
Copy link
Member

@optionsome optionsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw I wonder if there is any reason for us not to include Turku's realtime now as well now in seutuplus?

app/configurations/config.matka.js Outdated Show resolved Hide resolved
app/configurations/config.varely.js Outdated Show resolved Hide resolved
@sharhio
Copy link
Contributor Author

sharhio commented Oct 4, 2023

There is no reason to not add Turku, in fact, it should be added.

@sharhio sharhio requested a review from optionsome October 9, 2023 06:27
@optionsome optionsome merged commit fc8989c into v3 Oct 9, 2023
5 checks passed
@optionsome optionsome deleted the DT-5977 branch October 9, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@optionsome optionsome Awaiting requested review from optionsome

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharhio @optionsome