Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger to service and repo configs. #8

Open
ryasmi opened this issue Oct 27, 2017 · 3 comments
Open

Add logger to service and repo configs. #8

ryasmi opened this issue Oct 27, 2017 · 3 comments

Comments

@ryasmi
Copy link
Member

ryasmi commented Oct 27, 2017

It's quite useful to have the logger (Winston.LoggerInstance) available in the service and repos. Adding this would break the compilation for dependents of jscommons.

@ryasmi
Copy link
Member Author

ryasmi commented Oct 31, 2017

Might also want to add the tracker to express presenter, service and repo configs.

@ryasmi
Copy link
Member Author

ryasmi commented Nov 17, 2017

Might also want to add a transactionId to Member Options and create a handler HOF for Express handlers that catches errors and creates the transactionId to be logged when catching errors and to be passed into the handlers.

@ryasmi
Copy link
Member Author

ryasmi commented Nov 21, 2017

Should also remove body parser! At least the JSON one to prevent "leaky mixins".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant