Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github plugin cannot distinguish between PRs and issues with an IssueCommentEvent #173

Open
LordAro opened this issue Nov 24, 2019 · 0 comments

Comments

@LordAro
Copy link
Member

LordAro commented Nov 24, 2019

As best as I can see, the only (short of checking for 'pull/' in URLs) way to distinguish between the two is to use the (undocumented) pull_request key in the issue block. Might need a handle_issue_comment function to deal with this, as you can't put conditionals in the format handlers (not a format string :( )

https://github.com/TrueBrain/DorpsGek/blob/569474db772add7be7260d01e4d5abc724d0d792/dorpsgek/events/pull_request.py#L32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant