-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚨 Fix SCSS Lint issues - Change @import to @use #5242
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5242 +/- ##
=======================================
Coverage 96.89% 96.89%
=======================================
Files 29 29
Lines 3381 3381
Branches 1415 1418 +3
=======================================
Hits 3276 3276
Misses 103 103
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
05d282c
to
4df7fff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
@balajis-qb you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PullRequest Breakdown
Reviewable lines of change
+ 25
- 18
98% SCSS
2% JSON
Type of change
Fix - These changes are likely to be fixing a bug or issue.
if this is fixing a lint issue, why is the linter currently not failing? Do we need to adjust the rules to make sure this behavior doesn't get used anymore? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, this seems like a pretty straightforward fix.
Ryan Lester <@buu700>
Reviewed with ❤️ by PullRequest
4df7fff
to
0a9c694
Compare
Hi @martijnrusschen, I updated the |
ok great. It seems there's a merge conflict, can you take a look |
Resolved the conflicts |
Description
This PR updates SCSS files to replace deprecated
@import
statements with@use
. The@use
rule improves modularity, enhances namspace management, and aligns with modern SCSS standards.Changes
@import
statements with@use
@use
namespaces.Contribution checklist