Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Fix SCSS Lint issues - Change @import to @use #5242

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

balajis-qb
Copy link

Description

This PR updates SCSS files to replace deprecated @import statements with @use. The @use rule improves modularity, enhances namspace management, and aligns with modern SCSS standards.

Changes

  • Replaced @import statements with @use
  • Updated variable and mixin references as needed to accommodate @use namespaces.

Contribution checklist

  • I have followed the contributing guidelines.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.89%. Comparing base (e479fc3) to head (7196d4b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5242   +/-   ##
=======================================
  Coverage   96.89%   96.89%           
=======================================
  Files          29       29           
  Lines        3381     3381           
  Branches     1415     1418    +3     
=======================================
  Hits         3276     3276           
  Misses        103      103           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

@balajis-qb you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 25
- 18

98% SCSS
2% JSON

Type of change

Fix - These changes are likely to be fixing a bug or issue.

@martijnrusschen
Copy link
Member

if this is fixing a lint issue, why is the linter currently not failing? Do we need to adjust the rules to make sure this behavior doesn't get used anymore?

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, this seems like a pretty straightforward fix.

Image of Ryan Lester <@buu700> Ryan Lester <@buu700>


Reviewed with ❤️ by PullRequest

@balajis-qb
Copy link
Author

if this is fixing a lint issue, why is the linter currently not failing? Do we need to adjust the rules to make sure this behavior doesn't get used anymore?

Hi @martijnrusschen,
Actually we got a warning while building the app.
image

I updated the .stylelintrc config to also check for no-import rule in scss. If needed, we can also run lint as a part of our pre-commit hook. Currently we're just running prettier as a part of pre-commit and running lint only in the GitHub workflow.
image

@martijnrusschen
Copy link
Member

ok great. It seems there's a merge conflict, can you take a look

@balajis-qb
Copy link
Author

Resolved the conflicts

@martijnrusschen martijnrusschen merged commit 2452507 into Hacker0x01:main Nov 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants