Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Steep slopes can be easily clipped through (JRB ship) #261

Open
thecozies opened this issue Dec 29, 2021 · 2 comments · May be fixed by #794
Open

Steep slopes can be easily clipped through (JRB ship) #261

thecozies opened this issue Dec 29, 2021 · 2 comments · May be fixed by #794
Labels
bug Something isn't working high priority Important, non-critical issue or feature / high priority
Milestone
3.1

Comments

@thecozies
Copy link
Contributor

issue is in master and throughout develop/refactor

the JRB ship is a great example, after the ship tilts enough the back wall turns into a steep slope that can be clipped through either by jumping or running
@thecozies thecozies added bug Something isn't working critical Extremely important issue or feature / highest priority labels Dec 29, 2021
@thecozies
Copy link
Contributor Author

2021-12-28_18-07-32.mp4

@gheskett gheskett added this to the 2.0.1 milestone Dec 29, 2021
@Arceveti
Copy link
Collaborator

This is caused by the exposed ceilings fix, since in vanilla the area behind that slope reads as a null floor because of the bottom of the ship. The slope becomes too steep that the vertical raycast (find_floor) just misses it entirely between quartersteps. Increasing the number of sub-frame steps mostly eliminates the issue, but it would probably be better to do some sort of raycasting between Mario positions to verify that he isn't moving through a floor.

@Arceveti Arceveti modified the milestones: 2.0.2, 2.1 Jan 11, 2022
@gheskett gheskett modified the milestones: 2.1, 2.2 Mar 15, 2022
@gheskett gheskett added high priority Important, non-critical issue or feature / high priority and removed critical Extremely important issue or feature / highest priority labels Mar 15, 2022
@gheskett gheskett linked a pull request Sep 5, 2024 that will close this issue
Ifdef several collision changes from vanilla + improved debug free move #794
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working high priority Important, non-critical issue or feature / high priority
Projects
3.1 (Distant Features)
Status: To do
Milestone
3.1
Development

Successfully merging a pull request may close this issue.

Ifdef several collision changes from vanilla + improved debug free move Arceveti/HackerSM64
3 participants
@gheskett @Arceveti @thecozies