let js2-mode support flow syntax

[HairyRabbit]

linked issues

• Support flow's annotations mooz/js2-mode#224
• Add support for Facebook Flow language syl20bnr/spacemacs#7119
• Fixes #7119 - Add support for Facebook Flow language syl20bnr/spacemacs#7208
• No syntax highliting with js2-mode and rjx-mode an-sh/flow-minor-mode#8

flow syntax supports

type annotation

• union type
• intersection type
• object type
• array type
• tuple type
• function type
• literal type
• maybe type
• typeof type
• primitive type

decls, exprs, stmts

• modules
• functions
• classes
• variables
• type aliases
• opaque type aliases
• interfaces
• type casing
• type utilities
• declares

note

• type casing exprs supported, but broken for print ast on test, works fine with syntax highlight.
• usually declares decls is not useful for me

screenshot

[saixmh]

Amazing! Big suceess!

[rNoz]

Happy to read this progress. Looking forward to get it upstream :D

[HairyRabbit]

@rNoz Merry Christmas 🎄

I will finish this work(maybe typescript supports), but I don't think the PR will be merge.

[rNoz]

@HairyRabbit Happy new year!
Your work is amazing ;) I will wait to see if I can replace js2-mode with yours, or get merged somehow.

[HairyRabbit]

@rNoz Yeap, just replace with:

(load "path/to/js2-mode/js2-mode.el")
(js2-mode)

can test the feature. Thanks for any feedback.

[aaronjensen]

Are you planning to release this as a different package if you don't plan to merge it upstream?

Should jsx support work? Currently opening tags seem to get the type annotation face and closing tags the string face...

[HairyRabbit]

@aaronjensen
wow~ I'm happy to do if anyone want to this.

The jsx supports was a bug, fixed on current version.

[aaronjensen]

Hmm, they're still not fontified for me unless I'm also using rjsx-mode as well, is that expected?

Why don't you plan on merging upstream? They may accept it.

If not, a package would be great.

[HairyRabbit]

@aaronjensen
Looks like js2-jsx-mode doesn't highlight the jsx tags, I also use rjsx-mode for my case :)
I will send PR when I works done with export { foo as bar } from 'm'

[shackra]

Is the author still accepting pull requests?

has the author made the paperwork (I talk about the copyright assignment) for a future pull request to upstream?

[HairyRabbit]

I haven't pull this request to upstream yet, because some features are still work in progress.