Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HS Extension Length = 0 #124

Open
kierank opened this issue Dec 6, 2023 · 1 comment
Open

HS Extension Length = 0 #124

kierank opened this issue Dec 6, 2023 · 1 comment

Comments

@kierank
Copy link
Contributor

kierank commented Dec 6, 2023

libsrt doesn't seem to like it too much if you set HS Extension Length = 0 (e.g for stream ID). The spec should clarify this is not allowed.

@kierank kierank changed the title Extension Length = 0 HS Extension Length = 0 Dec 6, 2023
@maxsharabayko
Copy link
Collaborator

I would say, given (until) there is no HS extension assuming or allowing its length to be zero, having the HS Extension Length = 0 means the handshake is invalid (as of now).
In case of further protocol evolution, the spec should probably allow zero HS extension length for certain extension types.
The tricky question is what to do with extension type not known to a certain protocol version: treat as invalid and reject or ignore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants