Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass app.yaml config to the adapter #61

Open
jameslounds opened this issue Dec 20, 2022 · 1 comment
Open

Pass app.yaml config to the adapter #61

jameslounds opened this issue Dec 20, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@jameslounds
Copy link

jameslounds commented Dec 20, 2022

I intend on making a PR to implement this, but figured an issue first for thoughts would make sense.

I'm using this for a project, and I need to create an extra script to run after building to add some extra stuff to the app.yaml - some of these things are variable like env_variables, or service (dev, staging or prod).

I think it would be useful for the adapter to accept another argument, which will be dumped as yaml into the resulting app.yaml

kit: {
  adapter: appengine('build', [], {
    service:  process.env.SERVICE ,
    instance_class: "F4",
    automatic_scaling: {
      min_instances: 1
    },
    inbound_services: [ "warmup" ]
  })
}
@HalfdanJ
Copy link
Owner

Currently the script does enable this by adding a app.yaml file to the root. The app.yaml gets merged with the generated app.yaml file. But i have also thought about this solution, and I'm open to adding that as another option

@HalfdanJ HalfdanJ added the enhancement New feature or request label Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants