Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to use "secure" cookies out of the box #127

Open
jkabat opened this issue Jul 24, 2024 · 0 comments
Open

Not possible to use "secure" cookies out of the box #127

jkabat opened this issue Jul 24, 2024 · 0 comments

Comments

@jkabat
Copy link

jkabat commented Jul 24, 2024

Recently because of security audit we were asked to set all consent cookies "secure". Right now it is impossible to configure, so my first option was to override it.

Since CookieHandler uses bound variable "httpOnly" my override ended up with an error:

A binding is configured for an argument named "$httpOnly" under "_defaults" in file "/var/www/html/vendor/connectholland/cookie-consent-bundle/DependencyInjection/../Resources/config/services.yaml", but no corresponding argument has been found. It may be unused and should be removed, or it may have a typo.

So my solution is to make a decorated service... and copy whole file over, which is pretty ugly,

Anybody has another advice? Or only PR on the bundle would solve it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant