Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form closes after response received - should be on button click #62

Open
sigma-technology opened this issue May 4, 2020 · 0 comments
Open

Comments

@sigma-technology
Copy link

Firstly, thank you for this excellent bundle.

Just a suggestion for a potential improvement - I've noticed that when running Symfony in dev mode, the form can take a few seconds to disappear because it seems to be waiting for the response from the endpoint (would be the same on a slow connection). It would probably be better for the form to disappear as soon as the Save / Accept All / Functional Only buttons are clicked.

It could reappear if it's failed for some reason, although if it has failed to save then the site has bigger issues than cookie permission :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

0 participants