From 7d51d62b2710bcf4e6bce3e6ba08032fd40d62d7 Mon Sep 17 00:00:00 2001 From: Matthias Erll Date: Tue, 13 Dec 2022 15:21:05 +0100 Subject: [PATCH] Added one-to-many joins, as there might be no match either --- sqlalchemy_filters/models.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/sqlalchemy_filters/models.py b/sqlalchemy_filters/models.py index 49a737f..98ba7de 100644 --- a/sqlalchemy_filters/models.py +++ b/sqlalchemy_filters/models.py @@ -61,11 +61,12 @@ def should_filter_outer_join_relationship(operator): def should_sort_outer_join_relationship(models): - return any( - column.nullable - for rel_model in models - for column in rel_model.prop.local_columns - ) + for rel_model in models: + if rel_model.prop.direction == symbol('ONETOMANY'): + return True + elif any(column.nullable for column in rel_model.prop.local_columns): + return True + return False def find_nested_relationship_model(mapper, field):