Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[General Bug] Debug Save File Mode enhancement does not save selected option when Debug Mode is turned off, unlike SoH. #814

Open
3 of 4 tasks
SuperBro64 opened this issue Oct 21, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@SuperBro64
Copy link

  • I have checked the known issues and searched Github to ensure this issue has not already been reported.
  • This is not a feature request, I know those belong on Discord/Github Discussions.

Description of the bug:

In both SoH and 2Ship, the Debug Save File Mode enhancement only appears when Debug Mode is turned on. In SoH, whichever option is selected for the enhancement gets saved when Debug Mode is turned off and back on. In 2Ship, however, the Debug Save File Mode enhancement gets reset to "Empty save" when Debug Mode is turned off and back on.

Can you reproduce? If so please list the steps:

  • No, I cannot reproduce this bug
  • Yes, here are the steps to reproduce the bug:
  1. Go to the Developer Tools menu tab.
  2. Turn Debug Mode on.
  3. Set Debug Save File Mode to something other than "Empty save".
  4. Turn Debug Mode off and then back on.
  5. Debug Save File Mode will be reset back to "Empty save".

Expected behavior:

Since the equivalent enhancement in SoH does not get reset when Debug Mode is turned off and back on, I think the same thing should happen in 2Ship, as well. Moreover, 2Ship's Better Map Select enhancement also only appears when Debug Mode is turned on, but that enhancement does get saved when Debug Mode is turned off and back on.

Screenshots or videos:

  1. Open Developer Tools tab
    image
  2. Turn Debug Mode on
    image
  3. Change Debug Save File Mode and Better Map Select enhancements
    image
  4. Turn Debug Mode off and back on
    image
  5. Better Map Select remains changed, Debug Save File Mode gets reset
    image

System Information:

  • OS: Windows 11
  • GFX Backend: OpenGL
  • Game Version: v1.0.2 (dev version built October 21, 2024, 16:13:25)
  • Rom Version: US 1.0
@SuperBro64 SuperBro64 added the bug Something isn't working label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant