Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume Sliders Do Not Adjust Incrementally Between 0% and 100% #854

Open
SalbugVR opened this issue Nov 14, 2024 · 9 comments
Open

Volume Sliders Do Not Adjust Incrementally Between 0% and 100% #854

SalbugVR opened this issue Nov 14, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@SalbugVR
Copy link

  • [✅] I have checked the known issues and searched Github to ensure this issue has not already been reported.
  • [✅] This is not a feature request, I know those belong on Discord/Github Discussions.

Description of the bug:

When adjusting the volume sliders, the percentage does not change incrementally and only jumps directly between 0% and 100%.

Can you reproduce? If so please list the steps:

  • [] No, I cannot reproduce this bug
  • [✅] Yes, here are the steps to reproduce the bug:
  1. Open Settings
  2. Go to Audio
  3. Adjust any of the volume sliders

Expected behavior:

I expect the volume sliders to increment to any value between 0% and 100%.

Screenshots or videos:

sBt9Qp9PmV.mp4

System Information:

  • OS: Windows 11
  • GFX Backend: Metal, OpenGL, or DirectX: DirectX
  • Game Version: Satoko Bravo 1.1.1
  • Rom Version: MM-US 1.0

Additional Information:

N/A

@SalbugVR SalbugVR added the bug Something isn't working label Nov 14, 2024
@Malkierian
Copy link
Contributor

Malkierian commented Nov 15, 2024

Do none of the other sliders have that issue? Like the Internal Resolution slider in Graphics? Or Axis sensititivies in Camera Enhancements?

@Malkierian
Copy link
Contributor

Check both the menubar and the new menu, if you would.

@Malkierian
Copy link
Contributor

Actually, just try this build out when it's done building: Malkierian#4

@SalbugVR
Copy link
Author

Yup. Works as intended on the test build.

TbNfzensk0.mp4

@Malkierian
Copy link
Contributor

Alright, now that I know what the issue was, I'll work on another build today with some diagnostic printing for you to run, if you're willing.

@SalbugVR
Copy link
Author

Yeah, may be some time but I can check on it when I'm free.

@Malkierian
Copy link
Contributor

Alright, PR'd the fix with #859. If you would download it when it's done building and verify I didn't undo the fix with some reversion management, I'd appreciate it.

@SalbugVR
Copy link
Author

Sanity check reports all clear~ 👍

QCQkTFPjzK.mp4

@Malkierian
Copy link
Contributor

Awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants