Weapon timer feels wrong

[a-beyblade]

This code doesn't implement surviv.io's timer system correctly:

survivreloaded-server/src/game/objects/player.ts

Lines 668 to 673 in 9cfcaf1

	weaponCooldownOver(): boolean {
	return Date.now() - this.activeWeapon.cooldown >= this.activeWeapon.cooldownDuration &&
	(this.activeWeaponInfo.weaponClass !== "sniper"
	? Date.now() - (this.activeWeaponInfo.switchDelay * 1000) >= this.activeWeapon.switchCooldown
	: true);
	}

In the "old system" before the double pump nerf around Sep 2018, it should be

weaponCooldownOver(): boolean { 
    return Date.now() - this.activeWeapon.cooldown >= this.activeWeapon.cooldownDuration; 
}

In the "new system" between that and their shutdown, it would involve the "free switch timer", which I describe in great detail at surviv-underclock/docs. In that document, effective switch delay roughly corresponds to weapon cooldown.

[a-beyblade]

I made a mistake: in the old system, switching should also replace the cooldown timer with the switch delay since the last switch, which would be

weaponCooldownOver(): boolean { 
    return Date.now() - this.activeWeapon.cooldown >= (weaponWasSwitchedAfterShot) ? this.activeWeaponInfo.switchDelay * 1000 : this.activeWeapon.cooldownDuration; 
}

(weaponWasSwitchedAfterShot) needs to be replaced with code that checks for whether the weapon was no-slowed.