Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes on screen files cause issues with .pot on CI #577

Open
tuliomir opened this issue Apr 9, 2024 · 0 comments
Open

Small changes on screen files cause issues with .pot on CI #577

tuliomir opened this issue Apr 9, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@tuliomir
Copy link
Collaborator

tuliomir commented Apr 9, 2024

During the execution of #567 , which changed no screen files, the CI accused that the .pot files were incorrect.

Looking at the the pot file after the update, it was identified that many of those changes were made by #555, a PR that passed successfully on CI and was merged to master. Three subsequent PRs also passed the CI and were successfully merged after it, and it only started to trigger CI errors on the mentioned 567.

This indicates that our current CI process does not validate all the changes that were made to screens translatable texts, and is triggered by criteria that is not obvious.

We should revisit this check_pot script and look for a way to fix this.

@tuliomir tuliomir added the bug Something isn't working label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant