Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate usage of HashRouter for React Router #611

Open
tuliomir opened this issue May 10, 2024 · 0 comments
Open

Investigate usage of HashRouter for React Router #611

tuliomir opened this issue May 10, 2024 · 0 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@tuliomir
Copy link
Collaborator

The purpose of this issue is to keep a yellow flag on our usage of the React Router v6.

Description

On #609 we moved our main router from the recommended BrowserRouter to the HashRouter to fix bugs with the built release version of the app.

At a first glance this will not cause any issues: the only side effect is that the application URLs will be less legible - but they are not read by the user nor the application itself directly: only through the router interface.

However, the official docs on the HashRouter explicitly do not recommend its usage. This is a yellow flag that should be considered whenever we make improvements or maintenances related to the router.

See PR 609 for more references and information on this issue.

@tuliomir tuliomir added the dependencies Pull requests that update a dependency file label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

1 participant