-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup static variables from FlxPoint / FlxRect / FlxMatrix #1698
Milestone
Comments
Make them private or remove them, using pooling instead? |
Gama11
added a commit
that referenced
this issue
Jan 24, 2016
Gama11
added a commit
that referenced
this issue
Jan 24, 2016
Gama11
added a commit
that referenced
this issue
Jan 24, 2016
I would use pooling, or in cases where the points are hit every frame, store them as static variables on the class that actually uses them. |
I've already done the cleanup, see the referenced commits. It's just the static flash objects that are leftover (but made private). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
These variables should be stored where they are used: https://github.com/HaxeFlixel/flixel/blob/dev/flixel/math/FlxPoint.hx#L16-L19
https://github.com/HaxeFlixel/flixel/blob/dev/flixel/math/FlxRect.hx#L13-L15
We should think about cleaning up this type of API bloat for this major release.
The text was updated successfully, but these errors were encountered: