Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split volume control into sfx and music #362

Closed
Gama11 opened this issue May 22, 2013 · 1 comment
Closed

Split volume control into sfx and music #362

Gama11 opened this issue May 22, 2013 · 1 comment
Assignees
Milestone

Comments

@Gama11
Copy link
Member

Gama11 commented May 22, 2013

Like already suggested in flixel-community, I think that the way flixel handles volume is too simple and that there should be two seperate volume values, FlxG.volumeMusic and FlxG.volumeSFX (or FlxG.volumeSound) instead of FlxG.volume.

While this would be a really simple change, I'm not sure what to do about the soundTray. It would be rather complex to allow it to manipulate both volumes individually. Plus, there would be more keys needed to make that happen (and the volume control already uses a lot), at least one to switch between the two volume bars. Of course, you could just make the soundTray control both volumes at once as well.

@gamedevsam
Copy link
Contributor

We shouldn't mess with the soundTray at all. There should be a global volume control that affects both Sfx and Music. Adding more options to control Sfx and Music volumes separately is a good idea, but these should be multiplied by the global volume so we don't lose any of the current functionality.

@ghost ghost assigned Gama11 Jul 3, 2013
@Gama11 Gama11 modified the milestone: 4.0.0 May 30, 2015
@Gama11 Gama11 closed this as completed in 656549d Jan 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants