Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCaml 5.3 compatibility #11989

Open
andyli opened this issue Feb 8, 2025 · 2 comments · May be fixed by #12044
Open

OCaml 5.3 compatibility #11989

andyli opened this issue Feb 8, 2025 · 2 comments · May be fixed by #12044
Assignees

Comments

@andyli
Copy link
Member

andyli commented Feb 8, 2025

Debian and Fedora have upgraded their OCaml to 5.3 in their distros, and the Haxe packages failed to build.

A Fedora packager, Jerry James, provided a patch, which can be applied on Haxe 4.3.4.
https://src.fedoraproject.org/rpms/haxe/blob/f42/f/haxe-ocaml5.3.patch

I've checked the patch can be applied on Haxe 4.3.6, but there is still a few compilation errors.

It would be great if a full fix can be made on the 4.3_bugfix and development branches. I will then turn the commit into a patch for packaging.

@kLabz kLabz self-assigned this Feb 8, 2025
@kLabz
Copy link
Contributor

kLabz commented Feb 8, 2025

I made 4.3_bugfix_ocaml5_2025 branch based off 4.3.6, where linux arm64 still fails to build (and macos-hl tests don't work), does that help? CI run

(I'll include this in 4.3_bugfix at some point but I'll also need to get CI green; might need to pull more updates from development)

@andyli
Copy link
Member Author

andyli commented Feb 9, 2025

Yes, that worked. Thanks!

@kLabz kLabz linked a pull request Mar 7, 2025 that will close this issue
5 tasks
@kLabz kLabz linked a pull request Mar 7, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants