Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Plugin doesn't work if notification permission is not allowed #188

Closed
HarelM opened this issue May 28, 2024 · 0 comments · Fixed by #189
Closed

[Android] Plugin doesn't work if notification permission is not allowed #188

HarelM opened this issue May 28, 2024 · 0 comments · Fixed by #189

Comments

@HarelM
Copy link
Collaborator

HarelM commented May 28, 2024

Describe the bug
In previous PR

I've added the notification permission request.
It seems that without this permission the plugin won't report GPS locations.
So there's a need to allow the user to accept this permission, but not obligate him to approve it.

To Reproduce
Steps to reproduce the behavior:

  1. Start location tracking
  2. Allow location permission
  3. Do not allow notification permissions
  4. Plugin reports unauthorized.

Expected behavior
Location should still be available even if notification is not allowed.

Desktop (please complete the following information):

  • OS: [e.g. iOS] Android
  • Version [e.g. 22] 14

Additional context
I did not fully test this scenario when introduction the previous feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant