Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featurizer.get_keys() does not honor candidate classes in context #514

Open
HiromuHota opened this issue Sep 22, 2020 · 0 comments
Open

Comments

@HiromuHota
Copy link
Contributor

Description of the bug

Unlike other methods (eg Featurizer.drop_keys() and Featurizer.upsert_keys(), Featurizer.get_keys() does not honor candidate classes in context but returns all feature keys no matter which candidate class they are associated with.
This is confusing.

See #511 (comment) for how this actually confused a user.

To Reproduce

This is a design error.

Expected behavior

These methods should behave similarly. Either

  • None of these honor candidate classes, or
  • All of these honor them.

Error Logs/Screenshots

N/A

Environment (please complete the following information)

  • Fonduer Version: 0.8.3

Additional context

Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant