Fix magic numbers #652
Merged
Fix magic numbers #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoizIqbal97
approved these changes
Mar 14, 2024
blargly
approved these changes
Mar 14, 2024
spco
approved these changes
Mar 14, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes the hardcoded django
content_typeids used in the backend, client, and workers.This enables the app to be deployed fully working.
The approach has been to make the backend to be responsible for the
content_type, and not trust the client, in two ways:ScanReportConceptis created through the API (when used by the workers, or the frontend), the content type is passed as a string, this is then used to lookup the content type ID.content_typeis used for frontend logic, mostly for rendering / filtering, a new API endpoint has been created to get the content type ID.Closes #637
Closes #641
Large diffs in the Javascript are Prettier working away.
Checks
Important: please complete these before merging.
changelog.md, including migration instructions if any.