Skip to content
This repository was archived by the owner on Nov 10, 2022. It is now read-only.

Improve unit tests #7

Open
jradtilbrook opened this issue Oct 10, 2018 · 1 comment
Open

Improve unit tests #7

jradtilbrook opened this issue Oct 10, 2018 · 1 comment

Comments

@jradtilbrook
Copy link
Member

The way the unit tests make assertions to check behaviour is not very good. It relies on the phpunit configuration forcing a test to fail if it makes no assertions. It should instead bind a local variable to the closures by reference, modify it in the closure and assert it has changed. Or perhaps there is an even better way than that.

@tspencer244
Copy link
Member

See #9 for my proposed solution. Also I think you forgot to tag this issue for Hacktoberfest!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants