Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying fefd.py and it keeps getting the error "ModuleNotFoundError: No module named 'femwell.mode_solver'" #193

Open
Andrew31s opened this issue Feb 6, 2025 · 3 comments

Comments

@Andrew31s
Copy link

Sorry this is my first time downloading packages and code from GitHub so I apologise if this is an easy fix.

I have installed femwell through the consol in spyder using pip install femwell, and copied the code directly from GitHub fefd.py. The error comes from the line "from femwell.mode_solver import plot_mode",

I am not sure what I have done wrong, because I have tried examples waveguide.py and fefd_2d.py and they work perfectly fine.

@HelgeGehring
Copy link
Owner

Hey Andrew!

the files in the package which are not documented should be seen more as "experimental". I.e. we started working on them but they are not yet finished (maybe I should move those to a dev-branch) nor tested.

For this one we moved the mode solver to a new location, so that file also needs to get that update (adjust import and adjust to the new API of the modesolver).
Feel free to do an PR on this :) I'm happy to help with feedback and guiding things :)

@Andrew31s
Copy link
Author

Hi Helge,

Sorry I did not realise it was not finished yet. Whats a PR? i am new to GitHub.

Thank you for your time,
Andrew

@HelgeGehring
Copy link
Owner

PR means Pull Request. I.e. if you want to go on with that file / have ideas how to improve it, you can propose changes to make it better for everyone :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants