Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interfacing Mammoth and OpusFilter #17

Open
6 tasks
TimotheeMickus opened this issue Sep 22, 2023 · 0 comments
Open
6 tasks

Interfacing Mammoth and OpusFilter #17

TimotheeMickus opened this issue Sep 22, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@TimotheeMickus
Copy link
Collaborator

In the long run, rather than having our custom transforms for data cleaning (as suggested b y #13), it would be better to leave it to a relevant third party, such as OpusFilter.

I'm mostly opening this issue for discussion and as a long-term project rather than expecting this to be handled soon.

As far as I can tell, one would need:

  • a contribution to OpusFilter to allow it to read and write through piping (or selecting some other tool that allows cleanup through piping)
  • a transform to handle passing the data from our iterators to the third party software for cleaning and back into the system:
    • booting a pipe in the warmup method
    • implement apply through e.g. a popen.read`
    • a graceful closure when training ends.
  • (optionally) a deprecation of current filters if their are no longer needed or redundant.

Note that there are several challenges ahead: in particular,

  • one will have to find a way around sub-process creation in multi-node settings
  • it's unclear how much effort would be required to implement the required behavior on the third party side (OpusFilter or other).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants