Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep or remove the wysiwyg? #378

Open
bjarneo opened this issue Feb 11, 2025 · 4 comments
Open

Keep or remove the wysiwyg? #378

bjarneo opened this issue Feb 11, 2025 · 4 comments

Comments

@bjarneo
Copy link
Member

bjarneo commented Feb 11, 2025

No description provided.

@ltguillaume
Copy link
Contributor

ltguillaume commented Feb 11, 2025

Do you mean the rich text editing? In that case, keep, absolutely!

Styling is quite often absolutely a requirement to properly relay sensitive information.

If anything, I'd even like to have the ability to show tables!

That said, #288 still doesn't work.

@bjarneo
Copy link
Member Author

bjarneo commented Feb 16, 2025

Looking into replacing quill with tip tap: https://tiptap.dev/docs/editor/getting-started/overview

@ltguillaume
Copy link
Contributor

ltguillaume commented Feb 16, 2025

Not a fan of the hovering toolbar and it seems needlessly flashy with AI integration and what not, but I read that it's quite modular and perhaps a fixed toolbar is an option, too. I think https://github.com/fastmail/Squire might also be a good alternative.

I haven't looked at the Hemmelig code for this part, but the issue with editors like this is of course the possible risk of serving malicious HTML code. For instance, here's what Squire says about it.

@bjarneo
Copy link
Member Author

bjarneo commented Feb 16, 2025

You can pick and choose what you use from Tiptap. Using it for another project. It can be as easy as the quill setup.

As for

possible risk of serving malicious HTML code

I am aware. The best thing would be to use markdown, and then render it to the user using i.e. react-markdown

If I decide to change the editor, this will be the approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants