Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with node-http-proxy (and http-proxy-middleware) #129

Open
aral opened this issue Jan 30, 2020 · 0 comments
Open

Incompatible with node-http-proxy (and http-proxy-middleware) #129

aral opened this issue Jan 30, 2020 · 0 comments

Comments

@aral
Copy link

aral commented Jan 30, 2020

Since express-ws modifies the path of incoming WebSocket requests it is incompatible with proxying WebSockets (as other servers do not understand or employ the same naming convention/fake GET route hack).

Going to look into whether the actual modification can be made within middleware that obeys the middleware chain so that it can happen only if the proxy server falls back through to the middleware chain without handling the upgrade itself (e.g., on a 404).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant