Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] FastAPI 서빙으로 변환 #4

Open
ssaru opened this issue Aug 6, 2020 · 0 comments
Open

[FEATURE] FastAPI 서빙으로 변환 #4

ssaru opened this issue Aug 6, 2020 · 0 comments
Assignees
@ssaru
Labels
enhancement New feature or request

Comments

@ssaru
Copy link
Member

ssaru commented Aug 6, 2020

🚀 Feature

  • Flask로 되어있던 Serving을 FastAPI로 변환합니다

Motivation

  • @soeque1 님께서 소개해주신 FastAPI가 아래의 이유로 훨씬 더 매력적이라 변경합니다.
  1. 공식적으로 Swagger UI를 지원(Flask는 Flask rest plus라는 것을 사용해야함)
  2. Flask보다 문서화가 잘 되어있음
  3. Python Backend Benchmark 결과에서 성능이 우수함

Pitch

Additional context
@ssaru ssaru added the enhancement New feature or request label Aug 6, 2020
@ssaru ssaru self-assigned this Aug 6, 2020
ssaru added a commit that referenced this issue Aug 6, 2020
@ssaru
feat: Flask serving을 FastAPI로 변환
c22d24e 
 Refs: #4
ssaru added a commit that referenced this issue Aug 6, 2020
@ssaru
feat: validation & error handling
0036d84 
 Refs: #4
@ssaru ssaru mentioned this issue Aug 6, 2020
Merged
2 tasks
ssaru added a commit that referenced this issue Aug 8, 2020
@ssaru
Merge pull request #5 from HephaestusProject/feature/#4-convert-fastapi
9e5fb67 
Feature/#4 convert fastapi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssaru ssaru

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ssaru