Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shortcut from Steam Non-Steam Game in the Steam Deck does not work sometimes #1905

Closed
arielj opened this issue Oct 15, 2022 · 6 comments

Comments

@arielj
Copy link
Collaborator

arielj commented Oct 15, 2022

Describe the bug

When I uninstall a game that was previously added as to Steam with the Add to Steam feature, the game does not get removed from Steam, even though the logs say it was.

EDIT: Using the Remove from Steam option also doesn't work, it does change the button to Add to Steam so it is doing something, but the game still shows up in the Steam library.

I think it might be related to me having 2 accounts registered? maybe adding is adding it to both accounts but removing is removing it from only one?

Add logs

There's no error in the logs and it mentions a successful removal:

Remove Steam images from Black Widow: Recharged
Black Widow: Recharged was successfully removed from Steam

Steps to reproduce

  1. Install a game
  2. Use the Add to Steam option
  3. Restart in Game mode to see the game added to the library
  4. Restart in Desktop mode and uninstall the game
  5. Restart in Game mode to see the game is still in the library

Expected behavior

Game should be removed from Steam when uninstalled.

Screenshots

No response

System Information

  • OS [e. g. "Ubuntu"]: Steam Deck
  • Heroic Version [e. g. 2.1.1]: 2.4.3

Additional information

Not sure if it's relevant, but I have 2 accounts registered in the Steam Deck.

@arielj arielj changed the title Uninstalling a game does not remove the Steam Non-Steam Game in the Steam Deck Remove shortcut from Steam Non-Steam Game in the Steam Deck does not work Oct 16, 2022
@arielj
Copy link
Collaborator Author

arielj commented Oct 16, 2022

Adding some of my findings. The problem seems to be that I have 2 accounts AND that I changed to Game mode before removing the shortcut (which I don't understand why it's a factor in this issue).

So, this works:

  • Add a shortcut (it gets added to both shortcuts.vdf)
  • Remove the shortcut (it gets removed from both shortcuts.vdf)

This does NOT work:

  • Add a shortcut (it gets added to both shortcuts.vdf)
  • Restart in game mode (verify the game is showing up)
  • Restart in desktop mode
  • Remove the shortcut (it only gets removed on the shortucts.vdf for the account that was not logged in game mode :S)

@arielj arielj changed the title Remove shortcut from Steam Non-Steam Game in the Steam Deck does not work Remove shortcut from Steam Non-Steam Game in the Steam Deck does not work sometimes Oct 16, 2022
@Nocccer
Copy link
Collaborator

Nocccer commented Oct 21, 2022

Ok i see. I think there is a problem in my code. I will look later, but i think i just return as soon as i removed the game from one shortcuts.vdf. I need to iterate over all. Maybe thats the problem, because i don't care about steam accounts.

@flavioislima
Copy link
Member

Is this still an issue?

@arielj
Copy link
Collaborator Author

arielj commented Dec 16, 2022

yes, it's still happening for me (after removing steam shortcut, it is only removed from one steam account and I have to remove them manually inside steam for the other). I'm not sure what's the fix though.

@Nocccer
Copy link
Collaborator

Nocccer commented Dec 16, 2022

I saw this happens if you remove the game and steam is still open. Steam somehow caches the old shortcut.vdf and write it back if you close steam.

I checked the code and actually i already iterate. I think it is a problem that steam sometimes caches and rewrite the shortcuts.vdf

@arielj
Copy link
Collaborator Author

arielj commented Jan 7, 2025

Closing this, I only had the issue with 2 steam accounts and haven't had 2 account in the same machine since then, it's either fixed or not important at this point.

@arielj arielj closed this as completed Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants