Skip to content

Commit 79c3df4

Browse files
acgoldmashefty
authored andcommitted
prov/psm: Remove psm as support was EOL several years ago
Signed-off-by: Adam Goldman <[email protected]>
1 parent 0527bda commit 79c3df4

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+20
-11131
lines changed

Makefile.am

-1
Original file line numberDiff line numberDiff line change
@@ -448,7 +448,6 @@ include prov/udp/Makefile.include
448448
include prov/verbs/Makefile.include
449449
include prov/efa/Makefile.include
450450
include prov/usnic/Makefile.include
451-
include prov/psm/Makefile.include
452451
include prov/psm2/Makefile.include
453452
include prov/psm3/Makefile.include
454453
include prov/gni/Makefile.include

README.md

+2-21
Original file line numberDiff line numberDiff line change
@@ -105,10 +105,10 @@ possible and all debug features will be disabled.
105105
Alternatively:
106106

107107
```bash
108-
$ ./configure --prefix=/opt/libfabric --enable-debug --enable-psm=dl && make -j 32 && sudo make install
108+
$ ./configure --prefix=/opt/libfabric --enable-debug --enable-psm3=dl && make -j 32 && sudo make install
109109
```
110110

111-
This will tell libfabric to enable the `psm` provider as a loadable library,
111+
This will tell libfabric to enable the `psm3` provider as a loadable library,
112112
enable all debug code paths, and install libfabric to the `/opt/libfabric`
113113
tree. All other providers will be enabled if possible.
114114

@@ -158,25 +158,6 @@ PSM2 on the host software stack, leading to better overall performance.
158158
See the `fi_opx(7)` man page for more details. See [Cornelis Customer
159159
Center](https://customercenter.cornelisnetworks.com/) for support information.
160160

161-
### psm
162-
163-
***
164-
165-
The `psm` provider runs over the PSM 1.x interface that is currently supported
166-
by the Intel TrueScale Fabric. PSM provides tag-matching message queue
167-
functions that are optimized for MPI implementations. PSM also has limited
168-
Active Message support, which is not officially published but is quite stable
169-
and well documented in the source code (part of the OFED release). The `psm`
170-
provider makes use of both the tag-matching message queue functions and the
171-
Active Message functions to support various libfabric data transfer APIs,
172-
including tagged message queue, message queue, RMA, and atomic
173-
operations.
174-
175-
The `psm` provider can work with the `psm2-compat` library, which exposes
176-
a PSM 1.x interface over the Intel Omni-Path Fabric.
177-
178-
See the `fi_psm(7)` man page for more details.
179-
180161
### psm2
181162

182163
***

configure.ac

-1
Original file line numberDiff line numberDiff line change
@@ -909,7 +909,6 @@ AS_CASE(["$LD"],
909909

910910
dnl Provider-specific checks
911911
FI_PROVIDER_INIT
912-
FI_PROVIDER_SETUP([psm])
913912
FI_PROVIDER_SETUP([psm2])
914913
FI_PROVIDER_SETUP([psm3])
915914
FI_PROVIDER_SETUP([sockets])

contrib/buildrpm/README

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,5 +87,5 @@ General parameters:
8787
Print usage message and exit.
8888

8989
Example usages of the script:
90-
buildrpmLibfabric.sh -omsv -i usnic -e sockets -e verbs -e psm libfabric-1.4.1.tar.bz2
90+
buildrpmLibfabric.sh -omsv -i usnic -e sockets -e verbs -e psm3 libfabric-1.4.1.tar.bz2
9191
buildrpmLibfabric.sh -omsv -c "--disable-silent-rules" libfabric-1.4.1.tar.bz2

contrib/intel/jenkins/common.py

-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ def run_command(command):
5050
]
5151
common_disable_list = [
5252
'usnic',
53-
'psm',
5453
'efa',
5554
'perf',
5655
'rstream',

fabtests/Makefile.am

-1
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,6 @@ nobase_dist_config_DATA = \
112112
test_configs/verbs/verbs.exclude \
113113
test_configs/usnic/all.test \
114114
test_configs/usnic/quick.test \
115-
test_configs/psm/all.test \
116115
test_configs/psm2/all.test \
117116
test_configs/psm2/verify.test \
118117
test_configs/psm2/psm2.exclude \

fabtests/man/fabtests.7.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -536,12 +536,12 @@ the list available for that test.
536536

537537
## An example with various options
538538

539-
run server: fi_rdm_atomic -p psm -s 192.168.0.123 -I 1000 -S 1024
540-
run client: fi_rdm_atomic 192.168.0.123 -p psm -I 1000 -S 1024
539+
run server: fi_rdm_atomic -p psm3 -s 192.168.0.123 -I 1000 -S 1024
540+
run client: fi_rdm_atomic 192.168.0.123 -p psm3 -I 1000 -S 1024
541541

542542
This will run "fi_rdm_atomic" for all atomic operations with
543543

544-
- PSM provider
544+
- PSM3 provider
545545
- 1000 iterations
546546
- 1024 bytes message size
547547
- server node as 123.168.0.123
@@ -591,11 +591,11 @@ By default if none of the options are provided, it runs all the tests using
591591
Various options can be used to choose provider, subset tests to run,
592592
level of verbosity etc.
593593

594-
runfabtests.sh -vvv -t all psm 192.168.0.123 192.168.0.124
594+
runfabtests.sh -vvv -t all psm3 192.168.0.123 192.168.0.124
595595

596596
This will run all fabtests using
597597

598-
- psm provider
598+
- psm3 provider
599599
- for different options and larger iterations
600600
- server node as 192.168.0.123 and client node as 192.168.0.124
601601
- print test output for all the tests

fabtests/test_configs/psm/all.test

-62
This file was deleted.

include/ofi_prov.h

-11
Original file line numberDiff line numberDiff line change
@@ -90,17 +90,6 @@ EFA_INI ;
9090
# define EFA_INIT NULL
9191
#endif
9292

93-
#if (HAVE_PSM) && (HAVE_PSM_DL)
94-
# define PSM_INI FI_EXT_INI
95-
# define PSM_INIT NULL
96-
#elif (HAVE_PSM)
97-
# define PSM_INI INI_SIG(fi_psm_ini)
98-
# define PSM_INIT fi_psm_ini()
99-
PSM_INI ;
100-
#else
101-
# define PSM_INIT NULL
102-
#endif
103-
10493
#if (HAVE_PSM2) && (HAVE_PSM2_DL)
10594
# define PSM2_INI FI_EXT_INI
10695
# define PSM2_INIT NULL

include/rdma/fabric.h

+6
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,9 @@ enum {
205205
FI_SOCKADDR_IN, /* struct sockaddr_in */
206206
FI_SOCKADDR_IN6, /* struct sockaddr_in6 */
207207
FI_SOCKADDR_IB, /* struct sockaddr_ib */
208+
/* PSMX provider is deprecated.
209+
* We will keep this value in order to save binary compatibility.
210+
*/
208211
FI_ADDR_PSMX, /* uint64_t */
209212
FI_ADDR_GNI,
210213
FI_ADDR_BGQ,
@@ -310,6 +313,9 @@ enum {
310313
FI_PROTO_RDMA_CM_IB_RC,
311314
FI_PROTO_IWARP,
312315
FI_PROTO_IB_UD,
316+
/* PSMX provider is deprecated.
317+
* We will keep this value in order to save binary compatibility.
318+
*/
313319
FI_PROTO_PSMX,
314320
FI_PROTO_UDP,
315321
FI_PROTO_SOCK_TCP,

include/windows/config.h

-9
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,6 @@
4747
/* Define to 1 if you have the <netlink/version.h> header file. */
4848
/* #undef HAVE_NETLINK_VERSION_H */
4949

50-
/* psm provider is built */
51-
/* #undef HAVE_PSM */
52-
5350
/* perf provider is built */
5451
#define HAVE_PERF 1
5552

@@ -62,12 +59,6 @@
6259
/* Define to 1 if you have the <psm2.h> header file. */
6360
/* #undef HAVE_PSM2_H */
6461

65-
/* psm provider is built as DSO */
66-
/* #undef HAVE_PSM_DL */
67-
68-
/* Define to 1 if you have the <psm.h> header file. */
69-
/* #undef HAVE_PSM_H */
70-
7162
/* Define to 1 if you have the <rdma/rsocket.h> header file. */
7263
/* #undef HAVE_RDMA_RSOCKET_H */
7364

man/fabric.7.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -200,11 +200,11 @@ FI_LOG_SUBSYS environment variables.
200200
separated fashion. If the list begins with the '^' symbol, then the list will
201201
be negated. By default all providers are enabled.
202202

203-
Example: To enable logging from the psm and sockets provider:
204-
FI_LOG_PROV="psm,sockets"
203+
Example: To enable logging from the psm3 and sockets provider:
204+
FI_LOG_PROV="psm3,sockets"
205205

206-
Example: To enable logging from providers other than psm:
207-
FI_LOG_PROV="^psm"
206+
Example: To enable logging from providers other than psm3:
207+
FI_LOG_PROV="^psm3"
208208

209209
*FI_LOG_SUBSYS*
210210
: The FI_LOG_SUBSYS environment variable enables or disables logging at the

man/fi_endpoint.3.md

-5
Original file line numberDiff line numberDiff line change
@@ -709,11 +709,6 @@ protocol value set to one.
709709
This adds reliable-datagram semantics over the NetworkDirect connection-
710710
oriented endpoint semantics.
711711
712-
*FI_PROTO_PSMX*
713-
: The protocol is based on an Intel proprietary protocol known as PSM,
714-
performance scaled messaging. PSMX is an extended version of the
715-
PSM protocol to support the libfabric interfaces.
716-
717712
*FI_PROTO_PSMX2*
718713
: The protocol is based on an Intel proprietary protocol known as PSM2,
719714
performance scaled messaging version 2. PSMX2 is an extended version of the

man/fi_getinfo.3.md

-8
Original file line numberDiff line numberDiff line change
@@ -636,10 +636,6 @@ fabric. See [`fi_av`(3)](fi_av.3.html).
636636
: Address is a Cray proprietary format that is used with their GNI
637637
protocol.
638638

639-
*FI_ADDR_PSMX*
640-
: Address is an Intel proprietary format used with their Performance Scaled
641-
Messaging protocol.
642-
643639
*FI_ADDR_PSMX2*
644640
: Address is an Intel proprietary format used with their Performance Scaled
645641
Messaging protocol version 2.
@@ -690,10 +686,6 @@ address_format[://[node][:[service][/[field3]...][?[key=value][&k2=v2]...]]]
690686
*FI_SOCKADDR_IN6*
691687
: Address is of type sockaddr_in6 (IPv6).
692688

693-
*FI_ADDR_PSMX*
694-
: Address is an Intel proprietary format that is used with their PSMX
695-
(extended performance scaled messaging) protocol.
696-
697689
# FLAGS
698690

699691
The operation of the fi_getinfo call may be controlled through the use of

man/fi_pingpong.1.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ given domains cannot communicate, then the application will fail.
7272
## Fabric Filtering
7373

7474
*-p \<provider_name\>*
75-
: The name of the underlying fabric provider (e.g., sockets, psm, usnic, etc.).
75+
: The name of the underlying fabric provider (e.g., sockets, psm3, usnic, etc.).
7676
If a provider is not specified via the -p switch, the test will pick one from
7777
the list of available providers (as returned by fi_getinfo(3)).
7878

0 commit comments

Comments
 (0)