Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Cosmetics showing in emotes, free camera and movement during emotes, and multiple cosmetics per slot #68

Open
2 tasks done
D-Captain-TE opened this issue Feb 23, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@D-Captain-TE
Copy link

D-Captain-TE commented Feb 23, 2023

I have checked that...

  • ...such a feature does not exist already
  • ...such a feature request has not been submitted already

Description

When emoting, it should be possible to attach the cosmetics the player is currently wearing to the animation. You have extra bones in the animation file that hold the backpack, hat, offhand, and armor which you can animate accordingly. That way, the rotations and positions of the armor stands can be adjusted accordingly.

That being said, it should also be possible to move around during the emote as well as have a free camera, I imagine you might only have to rotate the model of the player by the y axis using the yaw value.

I would also like to suggest letting players equip multiple cosmetics per slot set by a config option.

Config Changes

free-camera: true
backpack-slots: 3
hat-slots: 3

@D-Captain-TE
Copy link
Author

addendum: whatever is in the player's hand can also be shown

@LoJoSho
Copy link
Member

LoJoSho commented Feb 23, 2023

I can definitely look into figuring that out in PlayerAnimator. As for free movement while in the emote, that's something that will require reworking how it currently works.

@LoJoSho LoJoSho added the enhancement New feature or request label Feb 23, 2023
@D-Captain-TE
Copy link
Author

D-Captain-TE commented May 5, 2023

image

Does this mean you're starting to figure out free movement or you have figured it out and I missed smth in the code? I've been looking at your guys' code to see if I can help with an implementation plan for cosmetics in emotes.

@D-Captain-TE D-Captain-TE changed the title [FEATURE] Cosmetics showing in emotes and free camera and movement during emotes [FEATURE] Cosmetics showing in emotes, free camera and movement during emotes, and multiple cosmetics per slot May 5, 2023
@LoJoSho
Copy link
Member

LoJoSho commented May 5, 2023

That was more of a TODO comment in case I ever got around to that section of code again.

@LoJoSho
Copy link
Member

LoJoSho commented May 5, 2023

I just noticed that you also added "multiple cosmetics per slot". Do not continue to pile onto the same issue with completely different issues. Open a new issue.

Furthermore, multiple cosmetics per slot would require significant reworking internally as the plugin assumes one cosmetic per slot. I don't even know how the plugin would show multiple cosmetics per slot (like, how would a player have 3 different leggings shown at the same time?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants