Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default server is incorrect sometimes #140

Closed
HimbeerserverDE opened this issue Dec 6, 2023 · 1 comment
Closed

Default server is incorrect sometimes #140

HimbeerserverDE opened this issue Dec 6, 2023 · 1 comment
Labels
bug Something isn't working critical Critical functionality is broken

Comments

@HimbeerserverDE
Copy link
Owner

HimbeerserverDE commented Dec 6, 2023

This is because looping over a map doesn't guarantee anything about the order. We can either use a config key to set the default server or use reflection to get the first entry if it is possible.

@HimbeerserverDE HimbeerserverDE added bug Something isn't working critical Critical functionality is broken labels Dec 6, 2023
@HimbeerserverDE
Copy link
Owner Author

Strategy:

  • Add a new mandatory config option for the default server (server name, string)
  • Fail if the option is unset or references an inexistent server
  • If last server is unavailable: inform client: fallback rather than using the default
  • If default is unavailable: fallback (should be working already, needs testing)

See #129 and #142 for details on load balancing and related features.

HimbeerserverDE added a commit that referenced this issue Dec 8, 2023
Not a full implementation of #142 yet: default server isn't handled as it needs to be refactored separately (#140).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical Critical functionality is broken
Projects
None yet
Development

No branches or pull requests

1 participant