Skip to content
This repository has been archived by the owner on Oct 18, 2023. It is now read-only.

FontValidator exits with 1 (instead of zero) on a successful run #48

Open
erniemarch2 opened this issue Mar 22, 2019 · 5 comments
Open

Comments

@erniemarch2
Copy link

When called from the command line (python script looping through several fonts in a folder),
font validator processes the first item and returns non-zero exit status of 1, causing
the python script to stop and not process the remaining items.

@HinTak
Copy link
Owner

HinTak commented Mar 23, 2019

You are aware that fontval itself takes multiple font arguments? As in '... -file font1.ttf -file font2.ttf ...'?

Also, if you really want to not stop on fatal errors, you do

'find /dir -type f -name "*.ttf" -exec FontValidator ... {} ;' ?

This is what I do for testing all 3500 fonts that fedora ships.

@miguelsousa
Copy link

You are aware that fontval itself takes multiple font arguments? As in '... -file font1.ttf -file font2.ttf ...'?

Yes, but we can't do that because the process we're running needs to call other tools on the same font.

Also, if you really want to not stop on fatal errors, you do
'find /dir -type f -name "*.ttf" -exec FontValidator ... {} ;' ?

I appreciate the suggestion, but we're not running FontValidator from the command-line, we're calling it from a Python subprocess.

@HinTak
Copy link
Owner

HinTak commented Mar 23, 2019

The exit status from mono when FontValidator is running outside of it seems to be correct, and it looks like a mono bug for the process of bundling mono with FontValidator. I'll file a bug upstream.

@miguelsousa
Copy link

@HinTak thank you 🙇

@HinTak
Copy link
Owner

HinTak commented Apr 6, 2020

I did file it upstream, mono/mono#13629 , just forgotten to come back to mention it here. Feel free to ping upstream...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants