Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lost support for IE8-10 #16

Open
indra-uolles opened this issue Oct 28, 2015 · 6 comments
Open

Lost support for IE8-10 #16

indra-uolles opened this issue Oct 28, 2015 · 6 comments
Labels

Comments

@indra-uolles
Copy link
Contributor

Now this plugin throws errors in IE8-10 because of "dataset" usage. I had to use old version of plugin without "dataset" and it worked fine.

@Holt59
Copy link
Owner

Holt59 commented Oct 28, 2015

I have created a new branch Holt59-patch-issue-16 which should fix the dataset issue (I have replaced dataset.xxxx by getAttribute("data-xxxx").

However I did not test it so it may be completely broken, but feel free to give a try for now (I'll do some checking as soon as I can!).

@Holt59
Copy link
Owner

Holt59 commented Oct 28, 2015

@indra-uolles A simple way to make classList it work in IE8-9 is to redefine classList (e.g. by using this).

I cannot do huge modification to the plugin right now, and I still have to decide if I want to add support for IE < 10 by modifying the plugin or simply by adding documentation on what to do to support IE < 10.

@indra-uolles
Copy link
Contributor Author

I liked this plugin because it was really lightweight and supported old IEs. I used it at two big websites and the functionality of this old version was enough for me. Maybe there are other people like me, with same demands. So you could add some info to documentation about IE support (like - plugin has full IE support until version xxx; if you want latest features and IE support you can blah-blah) and maybe not to bother with modifyng the plugin.

@Holt59 Holt59 changed the title lost support for IE8-10 because of "dataset" Lost support for IE8-10 Oct 29, 2015
@Holt59
Copy link
Owner

Holt59 commented Oct 29, 2015

@indra-uolles I am trying to re-add support for IE8-9, I will push some update to the Holt59-patch-issue-16 branch (I have renamed the issue since this is not related only to dataset anymore).

@Holt59 Holt59 added the bug label Oct 29, 2015
@Holt59
Copy link
Owner

Holt59 commented Dec 8, 2015

Support for IE8-10 should be back on branch Holt59-patch-issue-16. I need to clean and do more checking before pushing it to master but you can try it if you want.

@indra-uolles
Copy link
Contributor Author

I tested it in IE8-11 in my last project, no errors now :)
In my last project I used datatable to sort data placed in a table with three columns. Data looked like this:

John Doe | "Some wonderful artpiece" | 1977-1979
Alice Moo | "Another wonderful artpiece" |
Ivan Sidorov | "Masterpiece" | 1990

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants