-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation is replaced by auto-generated RBI comments. #17167
Comments
I opened a PR upstream: Shopify/tapioca#1885 🤞 |
Thanks for issues @reitermarkus and @dduugg! |
We can also patch Tapioca if upstream doesn't accept the patch (early feedback isn't positive) 🙈. Something like: https://github.com/Homebrew/brew/compare/tapioca-patch?expand=1 |
@dduugg This would work fine for me, monkey-patching like this is IMO fairly inconsequential when we're not exposing it to end-users. |
@dduugg, fine by me. We can always revert it once it is fixed upstream. |
Upstream PR was accepted, this will be fixed in the next tapioca release |
brew doctor
outputVerification
brew doctor
output" above saysYour system is ready to brew.
and am still able to reproduce my issue.brew update
twice and am still able to reproduce my issue.brew install wget
. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.brew config
outputWhat were you trying to do (and why)?
Documentation for e.g.
RuboCop
s only shows auto-generated comments from RBI files:From https://rubydoc.brew.sh/RuboCop/Cop/Homebrew/Blank.html:
What happened (include all command output)?
I assume the reason is that
yard-sorbet
is run last. It should be changed to skip any comments in RBI files.What did you expect to happen?
Original documentation should be shown.
Step-by-step reproduction instructions (by running
brew
commands)The text was updated successfully, but these errors were encountered: