Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt@5: add patch for binutils >= 2.41 #889

Merged
merged 1 commit into from
Sep 19, 2023
Merged

qt@5: add patch for binutils >= 2.41 #889

merged 1 commit into from
Sep 19, 2023

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Aug 28, 2023

Modified version of patch for qt@5
Only the paths of the files to patch have been changed

Modified version of patch for qt@5
Only the paths of the files to patch have been changed
@cho-m
Copy link
Member

cho-m commented Aug 28, 2023

If it's only the path, couldn't we use patch's DSL, e.g. directory "src/3rdparty/chromium/third_party/ffmpeg" or whatever subdirectory Qt is using?

@iMichka
Copy link
Member Author

iMichka commented Aug 28, 2023

We can, I did not know this possibility existed. I can try it but unpack times are long for qt@5 so testing this is always long an tedious, especially if you make a typo .. the patch step is always quite late, especially as we do a rm_r "qtwebengine" in the formula and then redownload the resource in place, and the only do the patching at the very end ...

I think it's not a big deal, just wanted to have this as a separate formula patch now to be able to get rid of the END block in the formula and move on to something more exciting than patching qt 5. When we drop qt5 we can just drop the whole patch folder.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Sep 19, 2023
@iMichka
Copy link
Member Author

iMichka commented Sep 19, 2023

Going to just merge this, it's not a big deal right now as this is for qt@5.

@iMichka iMichka merged commit 8fb0626 into Homebrew:master Sep 19, 2023
@iMichka iMichka deleted the qt branch September 19, 2023 11:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants