Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stella: revert Convert stringstream::view() to stringstream::str() for ventura builds #977

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

@chenrui333 chenrui333 changed the title Revert "Convert stringstream::str() to stringstream::view() where applicable." stella: revert Convert stringstream::view() to stringstream::str() for ventura builds Jan 23, 2025
@chenrui333 chenrui333 requested a review from a team January 23, 2025 19:45
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as long as merged upstream!

@chenrui333
Copy link
Member Author

upstream is not quite responsive, since we have already used the patch for the formula, I am going to merge it for now.

@chenrui333 chenrui333 merged commit cac6b12 into master Jan 27, 2025
3 checks passed
@chenrui333 chenrui333 deleted the stella-7.0c-patch branch January 27, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants