Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open-mpi 5.0.5 #177756

Merged
merged 6 commits into from
Oct 3, 2024
Merged

open-mpi 5.0.5 #177756

merged 6 commits into from
Oct 3, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner labels Jul 18, 2024
@chenrui333
Copy link
Member

  checking size of Fortran CHARACTER... configure: WARNING: Could not determine size of CHARACTER
  configure: WARNING: See config.log for details
  configure: error: Cannot continue

@samford samford added the build failure CI fails while building the software label Jul 18, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jul 21, 2024
@chenrui333 chenrui333 added in progress Stale bot should stay away and removed stale No recent activity labels Jul 21, 2024
@chenrui333
Copy link
Member

  checking size of Fortran CHARACTER... configure: WARNING: Could not determine size of CHARACTER
  configure: WARNING: See config.log for details
  configure: error: Cannot continue

did not see in my local

checking if Fortran compiler supports CHARACTER... yes
checking size of Fortran CHARACTER... 1
checking for C type corresponding to CHARACTER... char
checking alignment of Fortran CHARACTER... 1
checking for corresponding KIND value of CHARACTER... C_SIGNED_CHAR
checking KIND value of Fortran C_SIGNED_CHAR... 1

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jul 21, 2024
@chenrui333
Copy link
Member

@chenrui333 chenrui333 changed the title open-mpi 5.0.4 open-mpi 5.0.5 Aug 15, 2024
@cho-m cho-m added CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. and removed build failure CI fails while building the software labels Sep 4, 2024
@fxcoudert
Copy link
Member

Fix the opencoarray test to match the new and improves paths

@cho-m
Copy link
Member

cho-m commented Sep 6, 2024

alpscore will also need a similar fix but seems like it impacts more files. Inreplacing via glob with audit_result: false may be simplest. There are undocumented/unofficial FindMPI cache variables that can use a non-REALPATH (MPI_(C|CXX|Fortran)_COMPILER_INCLUDE_DIRS), but probably not a good idea to use variables that aren't included at https://cmake.org/cmake/help/latest/module/FindMPI.html

cp2k failure needs to be looked into. The serial ssmp passes while mpirun'd psmp fails so seems to be impacted by new open-mpi.

@cho-m
Copy link
Member

cho-m commented Sep 29, 2024

alpscore was fixed in 22c750b

So cp2k is the only blocker. EDIT: we did update to a new version in #184026 if that helps.

@cho-m cho-m added the long dependent tests Set a long timeout for dependent testing label Oct 2, 2024
@cho-m
Copy link
Member

cho-m commented Oct 3, 2024

CP2K failure might be an Open MPI bug.

I can confirm CP2K test:

  • Works with Open MPI 5.0.3 (even after rebuild)
  • Fails with Open MPI 5.0.5 (also tried rebuilding CP2K and switching to mpi_f08)
  • Works with Open MPI HEAD

Failure is stalling at "DBCSR STATISTICS" display. Not sure if deadlocked or something else yet.

@cho-m
Copy link
Member

cho-m commented Oct 3, 2024

Backported open-mpi/ompi@2d3ad2b as inreplace to avoid regenerating configure.

@cho-m cho-m added ready to merge PR can be merged once CI is green and removed in progress Stale bot should stay away labels Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 3, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 3, 2024
Merged via the queue into master with commit 1380e92 Oct 3, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the bump-open-mpi-5.0.4 branch October 3, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long dependent tests Set a long timeout for dependent testing ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants