-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
julia 1.11.0-rc4 #192116
base: master
Are you sure you want to change the base?
julia 1.11.0-rc4 #192116
Conversation
Test failure is
We should probably find a way to convince this to write inside |
Can probably try deleting if Base.get_bool_env("CI", false)
@info "Writing test result data to $(@__DIR__)"
write_testset_json_files(@__DIR__, o_ts)
end |
After that fix, the next part of test failed. Not sure what it is trying with the
|
Could just skip it, maybe, as long as |
Bit worried about segfault. Also, looks like release is soon - JuliaLang/julia#55953 |
Looks like we did report an issue when bumping |
Getting closer. ARM macOS passes. Intel macOS doesn't seem to be picking up bundled curl. |
4cf0a13
to
133931a
Compare
Tried switching to smaller testcase which should have cut down time by ~1min:
vs
However, full test is still going beyond 5min limit. The startup time of |
julia: update inreplace Co-authored-by: Carlo Cabrera <[email protected]>
While building the 1.11.0-rc4 in Homebrew[^1] in preparation for 1.11.0 release (and to confirm Sequoia successfully builds) I noticed some odd linkage for our Linux builds, which included of: 1. LLVM libraries were linking to `libedit.so`, e.g. ``` Dynamic Section: NEEDED libedit.so.0 NEEDED libz.so.1 NEEDED libzstd.so.1 NEEDED libstdc++.so.6 NEEDED libm.so.6 NEEDED libgcc_s.so.1 NEEDED libc.so.6 NEEDED ld-linux-x86-64.so.2 SONAME libLLVM-16jl.so ``` CMakeCache.txt showed ``` //Use libedit if available. LLVM_ENABLE_LIBEDIT:BOOL=ON ``` Which might be overriding `HAVE_LIBEDIT` at https://github.com/JuliaLang/llvm-project/blob/julia-release/16.x/llvm/cmake/config-ix.cmake#L222-L225. So just added `LLVM_ENABLE_LIBEDIT` 2. Wasn't sure if there was a reason for this but `libccalllazy*` had mismatched SONAME: ```console ❯ objdump -p lib/julia/libccalllazy* | rg '\.so' lib/julia/libccalllazybar.so: file format elf64-x86-64 NEEDED ccalllazyfoo.so SONAME ccalllazybar.so lib/julia/libccalllazyfoo.so: file format elf64-x86-64 SONAME ccalllazyfoo.so ``` Modifying this, but can drop if intentional. --- [^1]: Homebrew/homebrew-core#192116
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Potentially the final RC - https://github.com/JuliaLang/julia/milestone/46