Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyqt@5 5.15.9 #135630

Merged
merged 5 commits into from
Aug 28, 2023
Merged

pyqt@5 5.15.9 #135630

merged 5 commits into from
Aug 28, 2023

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Jul 3, 2023

Follow-up to #132437.

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue legacy Relates to a versioned @ formula labels Jul 3, 2023
@carlocab carlocab marked this pull request as ready for review July 3, 2023 04:29
@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jul 3, 2023
@carlocab
Copy link
Member Author

carlocab commented Jul 3, 2023 

  sip-install: /private/tmp/pyqtA5-20230703-10911-k2l2bc/PyQt5-5.15.7/sip/QtCore/qprocess.sip: line 99: column 5: 'Q_PID' is undefined

Any idea, @paperchalice?

@carlocab carlocab added help wanted Task(s) needing PRs from the community or maintainers build failure CI fails while building the software labels Jul 3, 2023
@paperchalice
Copy link
Contributor

Could we use pyqt 5.15.9 here?

@carlocab carlocab changed the title pyqt@5: revision bump (re2 20230601) pyqt@5 5.15.9 Jul 3, 2023
@carlocab carlocab added long build Set a long timeout for formula testing CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed help wanted Task(s) needing PRs from the community or maintainers build failure CI fails while building the software labels Jul 3, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jul 3, 2023
@carlocab carlocab added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jul 3, 2023
@carlocab carlocab mentioned this pull request Jul 3, 2023
Merged
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jul 3, 2023
@chenrui333 chenrui333 mentioned this pull request Jul 3, 2023
Merged
@carlocab carlocab added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-linux-self-hosted Build on Linux self-hosted runner labels Jul 4, 2023
@carlocab carlocab force-pushed the pyqt5-re2 branch 2 times, most recently from 89e919b to 96cb7e5 Compare July 4, 2023 05:50
@cho-m
Copy link
Member

cho-m commented Jul 4, 2023

Looks like qt@5 build is failing on Linux. Revision bump is necessary to fix failure from re2 where linkage is to previous libre2.so.10 rather than libre2.so.11.

We could choose to prioritize macOS and get pyqt@5 version update out first by moving qt@5 revision bump to separate PR.

@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jul 4, 2023
@carlocab carlocab added help wanted Task(s) needing PRs from the community or maintainers build failure CI fails while building the software labels Jul 5, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Aug 21, 2023
@iMichka iMichka added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Aug 23, 2023
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Aug 23, 2023
@iMichka
Copy link
Member

iMichka commented Aug 23, 2023

Ok. qt/pyqt have now been fixed with the same strategy (dropping re2).

I added the binutils patch with modified paths (it's a little bit quick and dirty, just to test if it works). We can move it formula patches later.

@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Aug 24, 2023
@chenrui333 chenrui333 removed the autosquash Automatically squash pull request commits according to Homebrew style. label Aug 24, 2023
@iMichka iMichka added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Aug 25, 2023
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Aug 25, 2023
@chenrui333 chenrui333 removed the autosquash Automatically squash pull request commits according to Homebrew style. label Aug 25, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Aug 26, 2023
@iMichka
Copy link
Member

iMichka commented Aug 28, 2023

Cool the bottle built. Here is the final patch Homebrew/formula-patches#889

@iMichka iMichka removed the build failure CI fails while building the software label Aug 28, 2023
@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Aug 28, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 28, 2023
Merged via the queue into Homebrew:master with commit a7d4c53 Aug 28, 2023
12 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cho-m cho-m cho-m left review comments

@iMichka iMichka iMichka left review comments

@github-actions github-actions[bot] github-actions[bot] approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

@SMillerDev SMillerDev SMillerDev approved these changes

Assignees
No one assigned
Labels
CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. help wanted Task(s) needing PRs from the community or maintainers legacy Relates to a versioned @ formula linux Linux is specifically affected long build Set a long timeout for formula testing outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@carlocab @paperchalice @cho-m @iMichka @SMillerDev @chenrui333 @BrewTestBot