Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear All Log Data #2056

Open
bjoer37 opened this issue Feb 2, 2021 · 6 comments
Open

Clear All Log Data #2056

bjoer37 opened this issue Feb 2, 2021 · 6 comments

Comments

@bjoer37
Copy link
Contributor

bjoer37 commented Feb 2, 2021

When clearing the all log data in File->Model Properties the open plots looses connections to the node variables. So when simulating after the clearance plots are empty.

To Reproduce

  1. Plot a variable after a simulation
  2. Keep the plot window open
  3. File->Model Properties and clear all the dog data
  4. Simulate again and study the plot window without plot data

Expected behavior
Plots might be empty. But, after the new simulation the variables plotted before the log data clearance would plot again in the plot windows.

Hopsan version (please complete the following information):
Version information is shown in the message widget when HopsanGUI is started

  • OS: Windows 10 ver 1809 OS Build 17763.973
  • Version: Info: HopsanCore 64-bit, Version: 2.16.0.20201108.1336 (Compiled in debug mode)
  • Build: compile it myrself
@peterNordin
Copy link
Member

peterNordin commented Feb 3, 2021

Ahh this good old request, I think it has been a desired feature since forever. To behave like the old fortran hopsan.
The problem is that the plotwindows contain "plot curves" connected to "log data variables". When the variables are deleted, the curves are also removed since the data that they depend on is removed. So nothing remains in the plot.

  • Maybe we should remember the names of the stuff plotted, in case the data would magically show up again. (names should be removed when curves are manually removed from plot)
  • Maybe plot windows should have the ability to contain variable names as text, that will autoplot if the data all of a sudden would show up after a simulation. That way we could also have free floating "scope components" that are not connected to anything. Not sure if that is useful, but could help de-clutter the workspace.

@bjoer37
Copy link
Contributor Author

bjoer37 commented Feb 4, 2021

Another solution would be to re-name it to "clear all old log data"?

  • Keeping the last generation and clear 1:(1-n) generations

It might destroy the purpose with the feature (I don't directly see how though).

@peterNordin
Copy link
Member

peterNordin commented Feb 8, 2021

Yes or maybe just add that one so both exist, hmm not even sure what the purpose of that button is, did not even know it was there.

@bjoer37
Copy link
Contributor Author

bjoer37 commented Feb 8, 2021

The nicest would be if the plow window keeps the link to the node variables and plot it again when a simulation is ran after the delete.

@peterNordin
Copy link
Member

peterNordin commented Feb 8, 2021

That is unfortunately impossible the way its implemented (the variables were deleted). But the list of possible solutions I wrote in my first reply may work. Short term fix is just to fix the button or add a new one.

But since this has been requested multiple times over the years, maybe I will actually try to solve it somehow.

@bjoer37
Copy link
Contributor Author

bjoer37 commented Feb 9, 2021

Yes. Your second list item would do the job good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants