Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apparent hashing of duplicated information in InnerProductArgPC::setup() function #21

Open
DanieleDiBenedetto opened this issue Jul 16, 2021 · 0 comments
Assignees

Comments

@DanieleDiBenedetto
Copy link
Collaborator

Currently, when generating the committer key, we also hash the max degree along with the generators (https://github.com/HorizenLabs/poly-commit/blob/dev/src/ipa_pc/mod.rs#L684):

let hash = D::digest(&to_bytes![&generators, max_degree as u32].unwrap()).to_vec();

It seems to me we are hashing a duplicated information, since already generators.len() == max_degree.
Can we remove it from the hash ?

@DanieleDiBenedetto DanieleDiBenedetto changed the title Apparent hashing of duplicated information in IpaPc::setup() function Apparent hashing of duplicated information in InnerProductArgPC::setup() function Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants